Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) ensure we only load JS on the import map #506

Merged
merged 1 commit into from
Aug 15, 2022
Merged

(fix) ensure we only load JS on the import map #506

merged 1 commit into from
Aug 15, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Aug 15, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Since we now directly create a script tag from the module URL, we should ignore anything on the importmap that isn't likely to resolve to JS file.

Screenshots

Related Issue

Other

@ibacher ibacher merged commit ca35053 into main Aug 15, 2022
@ibacher ibacher deleted the only-load-js branch August 15, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacButko ZacButko ZacButko approved these changes

@manuelroemer manuelroemer Awaiting requested review from manuelroemer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibacher @ZacButko